fix(combobox): Do not clear the input when no item is selected #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mannycarrera4
approved these changes
Jul 17, 2023
| if ( | ||
| document | ||
| .querySelector(`[data-id="${model.state.cursorId}"]`) | ||
| ?.getAttribute('aria-disabled') !== 'true' |
There was a problem hiding this comment.
Originally the conditional was:
document.querySelector(`[data-id="${model.state.cursorId}"]`)"If the element exists, continue". Later we added the requirement that the element should not be disabled via aria-disabled. The updated logic turned out to be "If the element exists AND is not disabled OR the element does not exist" when it should be "If the element exists AND is not diabled"
1 flaky tests on run #5968 ↗︎
Details:
|
|||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the accidental logic that closes the menu and clears the input when no item is selected.
Fixes: #2288
Release Category
Components
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Go to the Autocomplete example and type "Peach" and hit the enter key. It should not clear the input